18:12:13 #startmeeting 18:12:13 Meeting started Tue Mar 10 18:12:13 2015 UTC. The chair is nickm. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:12:13 Useful Commands: #action #agreed #help #info #idea #link #topic. 18:12:15 oh sonofa 18:12:15 hi 18:12:17 it's a meeting 18:12:18 trac ate my comment 18:12:48 weasels ripped my flesh 18:12:54 tx 18:12:59 nickm: may I suggest you append #startmeeting with the name of your meeting (maybe "patch_workshop" in this case), 18:13:04 it makes finding the logs on the dir listiong much easier 18:13:11 asn: will try to remember 18:13:28 yeah i also forget some time 18:13:29 s 18:15:17 * nickm looks at 14845 18:15:50 ok, so random administravia 18:16:04 we are not moving our meetings, because daylight savings is for suckas. T/F? 18:16:22 dgoulet: looks plausible to me? 18:16:39 (and our meeting times are specified in UTC, which does not do this sillyness) 18:16:52 our meeting times are indeed specified in UTC 18:16:52 ( Yawning fwiw i agree with your evaluation in #15213 ) 18:16:54 Yawning: Well, I could just reschedule everything around US EST/EDT for my benefit. 18:16:56 nickm: what do you mean? 18:17:09 but that would be a bit authoritarian 18:17:53 (asn: It'll be fun to write for someone, but I don't see it being all that useful, that's all. Novel approaches may prove me wrong) 18:18:13 maybe I should lorax tag that 18:18:50 the only one I'm unsure about is the weekly tor dev meeting at 0830 my time which is probably now at 0930 my time, but 0630 west-coast-us time 18:19:04 nickm: I belive the person with the most scheduling time constrains is yourself? 18:19:13 yes and no 18:19:17 hi isabela! 18:19:37 beyond, "no matter what hour we schedule these for, Yawning will suffer" 18:19:38 I don't support having anybody wake up before 0830 localtime, or stay awake past 2200 localtime 18:20:00 my own constraints are mild in comparison 18:20:06 I don't think that is actually possible unless we have no one on the west coast of the US 18:20:25 tor patch for #14845 looks good to me, but I'd rephrase the error message(s) maybe. 18:20:33 Yawning: then we might have to be flexible. 18:20:50 rl1987: how so? 18:20:51 rl1987: feel free to add it to the ticket, thanks! :) 18:21:44 nickm: we have people living between UTC+9 (me) and UTC-7/8 (PDT/PST) 18:21:57 maybe first one should say "incorrect address (wrong length)" or something 18:22:45 lemme update the ticket. 18:23:27 ilv: i just read your status report for GetTor and cursorily read sections of the codebase… great work! 18:24:02 ilv: if you ever want/need review for something, i'm willing to help 18:24:32 nickm: I am a early bird / wouldn't mind having a 6:30 meeting one day a week 18:24:39 Yawning: perhaps we need multiple meeting times to find something that works for (nearly everyone) and another thing that works for (nearly everyone) 18:24:48 isabela: whoa, that's amazing 18:24:58 nickm: tbh I'm fine with odd hours 18:25:12 since my biological clock doesn't match local time regardless of where I live 18:25:15 when I think of 6:30 I think of being grumpy and rude and biological 18:25:39 lol 18:25:40 ahah 18:25:44 so I guess schedule around west coast US <-> europe and I'll deal 18:26:14 we'll do tomorrow at the usual time and talk about how to work with that as part of the meeting 18:26:49 * isabela was at my old office at 6am everyday for6 months straight 18:27:14 and... were you okay with that? 18:27:26 just because you've done it doesn't mean it's okay for you to do it. :) 18:27:40 rl1987: kind of disagree on what you want 18:27:51 if we want to get into that sort of business we should ad 18:28:27 int is_valid_rendservice_addr(const char *addr, char **reason); 18:28:29 or something 18:28:39 nickm: giving the workload I had, it was actually better to do that way 18:28:56 to rendcommon.[h,c] 18:29:25 because going through all the code if/when we add ed25519 hs adrs will totally suck 18:29:30 Yawning: hrm this kind of helper function would be very useful to me also but I would put it public though 18:29:33 if we splatter more checks throughout the code 18:29:38 yes, public 18:29:39 Yawning: I currently use it for the control port 18:29:48 note the no static in my prototype 18:29:51 :P 18:30:00 ah, sorry namespace confused me :P 18:30:07 Yawning: well, y'all could just review 12498 so I could merge it and we could all go and have a party with cakes and bubbly wine and fancy dresses 18:30:17 nickm: and beers 18:30:17 and will wear the fanciest outfit of all! 18:30:30 dgoulet: indeed, and beers 18:30:46 but, a helper function that validates rend service addresses, returns a resason for why we hate it, and 0/NULL if it's good 18:30:55 will probably be very useful 18:30:57 +1 on that 18:31:10 yeah I agree with that. 18:31:23 dgoulet: you have code that'll use it immediately, file the ticket? 18:31:46 Yawning: I do have this yes, I can get into that 18:31:48 (then our control port spew can also be more informative, eg: complain about base32 alphabet issues etc) 18:32:01 well, you don't need to write it 18:32:04 >.> 18:32:16 I'm lost 18:32:38 the patch 18:32:41 just file the ticket 18:32:44 >.> 18:32:58 you want me to file a ticket for a patch you have?... 18:33:06 * rl1987 tries to look at #12498 18:33:09 no, file a ticket so we actually write the helper 18:33:17 now that we think it's a good idea 18:33:31 unless you just want it as part of this hs thing 18:33:31 Yawning: lol... yes I'll open the ticket and attached a patch for it ;) 18:33:36 :D 18:33:56 english hard at 0330 local time 18:34:24 I probably don't know enough crypto for this. 18:34:57 dgoulet: rest of the patch looks ok 18:35:21 Yawning: ack on the ticket? :) 18:35:38 we can get the is valid addr after 18:39:33 so is there a patch we should all talk about for a bit or should I endmeeting? 18:40:12 dgoulet: rend_cache_entry_t *e maybe const? 18:40:21 is anyone else looking at 12498_ed25519_keys_v5 ? 18:40:46 attempts to modify e should result in the compiler complaining if we can 18:40:58 but that's a nitpick since we don't 18:41:03 Yawning: we modify e though... 18:41:04 (acking) 18:41:13 modify value of e 18:41:30 ugh, explain hard 18:41:35 yeah I guess we could 18:42:15 cost rend_cahce_entry_t *e 18:42:31 pointer to constant data or w/e 18:42:51 wow, I just failed at typing repeatedly 18:47:40 #endmeeting? 18:47:52 think nickm needs to do that 18:48:06 I put #12498 on my whiteboard of doom 18:48:18 which I use for TODO tracking 18:50:55 Yawning: It was a thing, but not a very big thing. 18:51:02 #endmeeting