15:03:06 <richard> #startmeeting Tor Browser Weekly Meeting 2024-06-10
15:03:06 <MeetBot> Meeting started Mon Jun 10 15:03:06 2024 UTC.  The chair is richard. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:03:06 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
15:03:28 <jwilde> o/
15:03:30 <richard> hello hello, the pad per usual -> https://pad.riseup.net/p/tor-tbb-keep
15:03:49 <richard> please update your section with your planned tasks this week and updates from last
15:04:36 <richard> hm
15:05:01 <richard> looks like riseup's certs are fucked somehow?
15:05:08 <PieroV> They work for me
15:05:09 <boklm> it works for me
15:05:17 <dan_b> worked for me
15:05:22 <dan_b> you on a dodgy network?
15:05:24 <richard> interesssting
15:05:26 <richard> yeah one moment
15:05:26 <richard> brb
15:06:52 <richard> ok much better
15:07:06 <richard> leave it to your local public library to fuck with your internet traffic ^^;
15:07:18 <richard> *anyway*
15:07:20 <richard> as i was saying
15:07:22 <richard> good morning
15:07:59 <richard> brizental: I made you a section at the bottomof that pad ( https://pad.riseup.net/p/tor-tbb-keep )
15:08:36 <richard> basically each week we record our planned todo list for the week, and update our todo's from previous weeks
15:09:01 <richard> and there is a section for discussion points or announcements at the top
15:09:02 <brizental> richard: thanks!
15:09:24 <richard> we also sort of techncically use this time to update our issues in gitlab w/ respect to the Doing/Next/Backlog labels
15:09:42 <richard> *ideally* whatever one is working on should be labeled Doing
15:10:08 <richard> but in reality i ususally treat the pad as the source of truth is someone asks me hey what is so and so working on rn since i know gitlab can be a pain to keep sync'd with the real world
15:10:24 <brizental> lol got it
15:10:43 <richard> so 13.5a9 failed to build over the weekend
15:10:57 <PieroV> My bad, I forgot to open a thread about updating translations
15:11:01 <richard> i didn't look into it because weekend, but my best guess is fallout from the localisation work on the windows installer?
15:11:07 <PieroV> Probably I only wrote that on IRC
15:11:14 <PieroV> And I could've done myself in the localization MR
15:11:30 <PieroV> (nightlies succeeded because they use the branch)
15:11:51 <richard> ahh, so i just need tore-run the localisation script and get latest hashes and re-tag a -build2?
15:11:57 <richard> need to re-run*
15:12:03 <PieroV> No, I took care of that
15:12:16 <richard> ok great :)
15:12:35 <PieroV> Also, relprep.py can do that :) (except it didn't find it needed to update the build number, for some reason git didn't fetch tags for me)
15:12:54 <PieroV> Anyway, ma1 ran builds on tb-build-02 and dan_b locally
15:13:00 <PieroV> Probably they're ready by now
15:13:09 <ma1> checking...
15:13:20 <ma1> yes, mine are done
15:13:31 <dan_b> they are not. mine crashed in the android but its back and going again
15:13:43 <dan_b> (this happened friday too, rerun and it was fine, so not sure whats up with that)
15:14:00 <dan_b> but i should have all the deps already built so should be a few hours only
15:14:02 <PieroV> dan_b: if it's Android it might be an OOM
15:14:08 <ma1> dan_b, are your mullvad ready for comparing hashes?
15:14:10 <dan_b> i have 64GB
15:14:34 <dan_b> no they come after tor-browser
15:14:37 <dan_b> :?
15:14:52 <dan_b> but yeah I do have a lot of IDEs running lol, maybe I'll close a few
15:15:09 <PieroV> I see. At a certain point builds failed to me after a BIOS upgrade because I needed to re-train memory
15:15:26 <dan_b> looool
15:15:31 <PieroV> So, it might be anything, good things our builds are reproducible :)
15:15:43 <dan_b> anyways i'm wake to keep an eye on it too. should be good
15:16:20 <thorin> /o
15:17:19 <richard> it looks like nearly everyone responded to the time poll i sent out last week re PieroV's patch review/walkthrough meeting times
15:17:53 <richard> seems the best time will be next Monday (17th), 1600 UTC or later
15:18:07 <richard> i'll send out a meeting invite for that shortly
15:18:09 <richard> hi thorin o/
15:18:10 <brizental> richard: i think i didn't get that, but that time works for me
15:18:26 <richard> yeah you probably weren't added to the email alias yet
15:18:45 <PieroV> I think people should start reviewing before that meeting if they have time though
15:19:11 <PieroV> I'm going to create a MR in a few hours, once we get the 128b1 tag
15:19:43 <PieroV> FWIW, FIREFOX_BETA_128_BASE has already been tagged
15:19:44 <richard> yes please^
15:20:02 <richard> and thanks henry-x for improving the workflow on the mega review ticket(s) :)
15:20:07 <ma1> and we already solved the mistery on one of the rebase issues (the betterboxing breakage) :)
15:20:18 <richard> the macOS-onl one?
15:20:26 <ma1> it was everywhere actually
15:20:31 <PieroV> And I'm doing pretty good with the 115-128 commentary
15:20:47 <PieroV> It was everywhere but only with new profiles for some reason
15:20:55 <PieroV> I wonder if the Chrome cached is to blame
15:20:57 <ma1> xul cache, probably
15:21:00 <ma1> yep
15:21:20 <PieroV> But we purge it on make deploy now that I think of it
15:21:25 <thorin> everything everywhere all at once ..a apparently .. this is why we uplift in a timely fashion so maintenance fail son upstream :)
15:21:26 <PieroV> Unless some cache remains
15:21:51 <ma1> I purge always it in my tb launching script, and in fact I could reproduce it on first run on my "old" profile
15:22:32 <richard> is there a potential upgrade/migration issue here, or is this just a dev build problem?
15:23:02 <ma1> no, it was just some CSS moved away in a file where it should not have been.
15:23:36 <PieroV> Yeah, there was a refactor upstream and I followed it
15:23:47 <ma1> the chrome cache may have hidden the problem by keeping the old CSS around.
15:24:02 <richard> ah ok
15:24:03 <richard> neat
15:24:07 <PieroV> But the JS contained the hardcoded name of the old CSS file
15:24:25 <PieroV> So, I'm reverting the migration
15:24:27 <ma1> and also the new CSS file could not be reached directly because it's an @import rather than a top level
15:24:50 <ma1> (we should iterate deeply, which is wasteful)
15:25:44 <ma1> anyway, I'm commenting in the rebase review issue so we can keep track of this.
15:26:47 <PieroV> We should probably add an inline comment
15:26:55 <PieroV> There's one already about the selector
15:27:40 <ma1> Yeah, it should be the same with "keep the rule(s) in this file!!!"
15:28:49 <richard> ok, anyone else have discussion topics for this meeting?
15:29:08 <PieroV> When are we discussing 13.5 QA?
15:29:16 <richard> anyone blocked on anything?
15:29:21 <PieroV> In the extra release meeting?
15:29:25 <PieroV> Oh, yes
15:29:27 <richard> we can do that now
15:29:32 <richard> or in the release meeting later
15:29:33 <PieroV> dan_b: ma1: I haven't set a reviewer in the addons
15:29:45 <PieroV> But I think one of you should have a look at that (or both :))
15:29:49 <PieroV> I tagged you earlier
15:30:10 <dan_b> i kinda skimed it but i dont know anything about AMO or how that worked 😕
15:30:24 <PieroV> ack, then ma1 probably :)
15:30:33 <dan_b> do we have a browser release meeting today?
15:30:44 <richard> yep
15:30:47 <richard> wait no
15:30:52 <richard> we should but we don't
15:31:06 <richard> let me update the calendar ^^;
15:31:11 <dan_b> lol
15:31:16 <thorin> does anyone want to talk about FPing? j/k .. nvm
15:31:25 <richard> the problem is i don't know what today is
15:31:32 <thorin> scrollbars anyone?
15:33:06 <richard> thorin: thx for the mega post in the scrollbar issue, i haven't had a chance to read it in depth yet  but it seems the takeaway is  overlays are already default everywhere (in esr-128) except windows 10
15:34:02 <PieroV> richard: we force Windows 11 to have the same scrollbars as Windows 10
15:34:13 <richard> so i think i'm fine defaulting in Win10 as well with some caveats depending
15:34:35 <richard> i think we're dependant on UX now for onboarding w/ a11y prefs in the future now
15:35:16 <PieroV> But yeah, probably doing the opposite could be a better idea for fping, less for accessibility (but I think we can hear about that upstream)
15:35:41 <richard> basically
15:35:59 <richard> regardless let's plan to flip the relevant pref in 14.0a1or a2 over the summer :3
15:37:00 <richard> alright, let's go over QA plan in the release meeting today (invite should have been jsut sent out)
15:37:13 <ma1> received
15:37:15 <richard> 1800 UTC in donuts' BBB room
15:39:03 <brizental> richard: i didn't get the invite :/ probably the alias issue again, would you mind sending it to me specifically?
15:39:34 <jwilde> richard: can you also add donuts' BBB link to the invite?
15:39:49 <brizental> well i guess it doesn't matter, i see i tin the enxtcloud calendar :D
15:40:06 <donuts> here's the link, for ref: https://tor.meet.coop/dun-b97-zx5-0dh
15:40:23 <jwilde> donuts: tyty!!
15:40:36 <donuts> yw! +1 for adding it to the invite :D
15:40:38 <brizental> also i see i am in fact in the list, lol
15:41:02 <brizental> oh wait a moment, by tor email is bea@torproject.org, not brizental@torproject.org
15:41:21 <richard> ooh
15:43:29 <richard> ok, invites updated; added link to the bbb room and fixed bea's email ^^;
15:43:45 <brizental> thanksss
15:43:58 <richard> alright that's all from me
15:44:07 <richard> unless there are objections, happy to end this meeting and catch up on emails :3
15:44:18 <dan_b> 👍
15:45:11 <PieroV> None from me
15:46:19 <richard> alright, have a great week everyone o/
15:46:23 <richard> #endmeeting